> Ok, what do you guys think about the attached diff.
>
>  If we move the libelf build to the build_path rather than the build root we
> can use the normal environment to build it. So CC/CXX/CFLAGS  will be
> correct so we won't have to special handle them in the libelf SConscript.

The downside of this is that libelf is compiled each time, right?
Doesn't seem to be a big problem.  Though, since CC and CXX are global
sticky options, it seems that BATCH and BATCH_CMD should be as well,
and that we should move this code:

    # Do this after we save setting back, or else we'll tack on an
    # extra 'qdo' every time we run scons.
    if env['BATCH']:
        env['CC']  = env['BATCH_CMD'] + ' ' + env['CC']
        env['CXX'] = env['BATCH_CMD'] + ' ' + env['CXX']


much higher in the file and outside of the for loop.
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to