I've actually gotten used to the if ( thing, although it took a bit of effort
and I still don't really care for it. I've been using both //this and // this
depending on what's around it, what the time of day is, etc. Neither really
bothers me. I started out using //this so that's what I tend to use, other
factors aside.
Gabe
Quoting Steve Reinhardt <[EMAIL PROTECTED]>:
> On the topic of style violations, I've seen an increasing number of 'if('
> and 'for(' (with no space) creeping in (see below). Another thing I've seen
> that irritates me (but isn't officially banned by the style code ... yet
> ...) is C++-style comments with no space between the // and the comment:
>
> int foo; //this is a foo
>
> Anyone else bugged by this?
>
> Steve
>
> % find src -name '*.cc' -o -name '*.hh' | xargs util/chkformat -nv | grep
> 'improper spacing' | sed -e 's/:.*//' | sort -u
> src/arch/alpha/faults.cc
> src/arch/alpha/ipr.cc
> src/arch/alpha/tlb.cc
> src/arch/mips/dsp.cc
> src/arch/mips/faults.cc
> src/arch/mips/isa_traits.hh
> src/arch/mips/regfile/int_regfile.cc
> src/arch/mips/regfile/misc_regfile.cc
> src/arch/mips/system.cc
> src/arch/mips/tlb.cc
> src/arch/mips/utility.hh
> src/arch/mips/vtophys.cc
> src/arch/sparc/faults.cc
> src/arch/sparc/intregfile.cc
> src/arch/sparc/linux/syscalls.cc
> src/arch/sparc/predecoder.hh
> src/arch/sparc/process.cc
> src/arch/sparc/regfile.cc
> src/arch/sparc/remote_gdb.cc
> src/arch/sparc/tlb.cc
> src/arch/x86/faults.cc
> src/arch/x86/insts/microldstop.cc
> src/arch/x86/insts/microregop.cc
> src/arch/x86/insts/static_inst.cc
> src/arch/x86/insts/static_inst.hh
> src/arch/x86/pagetable_walker.cc
> src/arch/x86/predecoder.cc
> src/arch/x86/predecoder.hh
> src/arch/x86/process.cc
> src/arch/x86/types.hh
> src/base/loader/elf_object.cc
> src/base/loader/hex_file.cc
> src/cpu/legiontrace.cc
> src/cpu/nativetrace.cc
> src/cpu/nativetrace.hh
> src/cpu/o3/inst_queue_impl.hh
> src/cpu/o3/rename_impl.hh
> src/cpu/simple/atomic.cc
> src/cpu/simple/base.cc
> src/dev/alpha/tsunami_cchip.cc
> src/dev/i8254xGBe.hh
> src/dev/intel_8254_timer.cc
> src/dev/mips/malta_cchip.cc
> src/dev/mips/malta_io.cc
> src/kern/tru64/tru64_events.cc
> src/mem/bus.cc
> src/mem/dram.cc
> src/mem/packet.hh
> src/mem/page_table.cc
> src/sim/process.cc
> src/sim/sim_object.cc
> src/sim/tlb.cc
> src/unittest/rangemaptest2.cc
>
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
