I'm in favor of ignoring the parenthesis warning. Gabe
Quoting nathan binkert <[EMAIL PROTECTED]>: > As usual the gnu guys are out to make our life easier. I've more or > less got things working with 4.3, but there are a couple of issues we > need to sort out. I'll also need people to compile M5 on as many > systems as possible to make sure that my changes don't break things. > (I'll commit the patches in a day or so) > > 1) G++ now complains about lack of parenthesis in expressions with > combinations of operators that are commonly screwed up. We can > disable the warning with -Wno-parentheses and ignore the issue. I > generally feel that people should know their order of operations, but > with so many people hacking, maybe it's worth it to fix them and > enable the warning. Examples > > a && b || c && d ===> (a && b) || (c && d) > a << b - c ===> a << (b - c) > > 2) hash_map is now deprecated and people are supposed to use > unordered_map which will be in the next C++ standard. Unfortunately, > it's not too easy to provide an adapter between the two without using > #define. We can ignore the error for now with -Wno-deprecated, but > we're going to have to bite the bullet at some point when hash_map is > really moved. To top things off, if you use unordered_map, you have > to set --std=c++0x or --std=gnu++0x. I'm inclined to disable the > warning, and just do whatever magic is necessary when things finally > break, but the downside of that is when they do break, it might be > harder to keep older versions of compilers working if we don't have > some sort of adapter. > > Anyone have any opinions? > > Nate > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
