> How's it a compiler error to do a unsigned integer comparison?
That's not the error.  The error is that in the else clause, it's
guaranteed that the array access will be beyond the end of the array.
That's the error.

> In the MIPS ISA, I believe a bunch of registers were added into int reg.
> file to maintain add in the MIPS MT /DSP compatibility.
Who did this/would know about this?  If those registers should exist

> However, this looks to be some shadow set register compatibility code that
> got added...
Who did this?

>> The functions readReg and setReg both check to make sure that "intReg
>> < NumIntRegs" and do something special if it is.  The confusion I have
>> comes from the fact that there is an else clause at all.  The else
>> clause in the setReg case goes ahead and writes a value beyond the end
>> of the array if the condition is false.
>
> In both cases it falls back to the original register mapping. For setReg it
> writes the intReg index and for readReg it reads the intReg index.
Right, but this access is out of bounds.

> I'm not sure how the shadow-set stuff was implemented or stressed so  I cant
> really say remove it with confidence. Looks like it would work tho...
How can we figure out what's correct since what's there is clearly not.

  Nate
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to