Why the double negative ("!yield_mask != 0")? Seems like this should either
be "!yield_mask" or "yield_mask == 0", but not something in between...
Steve
On Fri, Sep 26, 2008 at 3:29 PM, Nathan Binkert <[EMAIL PROTECTED]> wrote:
> changeset eb5664be6075 in /z/repo/m5
> details: http://repo.m5sim.org/m5?cmd=changeset;node=eb5664be6075
> description:
> Use logical operator instead of bitwise operator for correctness.
>
> diffstat:
>
> 0 files changed
>
> diffs (24 lines):
>
> diff -r c2db27fc4f27 -r eb5664be6075 src/arch/mips/mt.hh
> --- a/src/arch/mips/mt.hh Fri Sep 26 08:18:55 2008 -0700
> +++ b/src/arch/mips/mt.hh Fri Sep 26 08:18:56 2008 -0700
> @@ -220,7 +220,7 @@
> warn("%i: Deactivating Hardware Thread Context #%i", curTick,
> tc->getThreadNum());
> }
> } else if (src_reg > 0) {
> - if (src_reg & !yield_mask != 0) {
> + if (src_reg && !yield_mask != 0) {
> unsigned vpe_control = tc->readMiscReg(VPEControl);
> tc->setMiscReg(VPEControl, insertBits(vpe_control,
> VPEC_EXCPT_HI, VPEC_EXCPT_LO, 2));
> fault = new ThreadFault();
> diff -r c2db27fc4f27 -r eb5664be6075 src/kern/tru64/tru64.hh
> --- a/src/kern/tru64/tru64.hh Fri Sep 26 08:18:55 2008 -0700
> +++ b/src/kern/tru64/tru64.hh Fri Sep 26 08:18:56 2008 -0700
> @@ -723,7 +723,7 @@
> abort();
> }
>
> - if (thread_index < 0 | thread_index > process->numCpus()) {
> + if (thread_index < 0 || thread_index > process->numCpus()) {
> cerr << "nxm_thread_create: bad thread index " << thread_index
> << endl;
> abort();
> _______________________________________________
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
