If a class has *any* virtual functions, it should have a virtual destructor because the assumption is that you will use the class polymorphically and you might delete the class with a pointer to the base class.
Nate On Sun, Jan 25, 2009 at 7:52 PM, Ali Saidi <sa...@umich.edu> wrote: > Gabe, > > I don't get a build error, but you can just remove the virtual > decorator on the functions in CopyEngineChannel. If it builds fine, > just commit that change. > > Ali > > On Jan 25, 2009, at 9:13 PM, Gabe Black wrote: > >> I'm getting ready to move the mass of patches I've built up into >> the >> head, but I've run into a build problem in the head. I get the >> following: >> >> build/X86_FS/dev/copy_engine.hh:50: warning: 'class >> CopyEngine::CopyEngineChannel' has virtual functions but non-virtual >> destructor >> >> which I'm assuming is easy to fix but I'm not familiar with that >> code so >> I didn't want to break anything. Could you please take a look at it >> Ali? >> >> Gabe >> _______________________________________________ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev >> > > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
