Don't we want to pick a default CPU stepping/model/family? It seems that we should pick a chip to "support"
Nate On Sun, Feb 1, 2009 at 5:18 PM, Gabe Black <[email protected]> wrote: > changeset da5f7e97958c in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=da5f7e97958c > description: > X86: Set/correct some default values for x86 parameters. > > diffstat: > > 2 files changed, 4 insertions(+), 4 deletions(-) > src/arch/x86/bios/ACPI.py | 2 +- > src/arch/x86/bios/IntelMP.py | 6 +++--- > > diffs (27 lines): > > diff -r b88edb9f3333 -r da5f7e97958c src/arch/x86/bios/ACPI.py > --- a/src/arch/x86/bios/ACPI.py Fri Jan 30 20:04:57 2009 -0500 > +++ b/src/arch/x86/bios/ACPI.py Sun Feb 01 16:59:34 2009 -0800 > @@ -94,6 +94,6 @@ > # here. > revision = Param.UInt8(2, 'revision of ACPI being used, zero indexed') > > - rsdt = Param.X86ACPIRSDT('root system description table') > + rsdt = Param.X86ACPIRSDT(NULL, 'root system description table') > xsdt = Param.X86ACPIXSDT(X86ACPIXSDT(), > 'extended system description table') > diff -r b88edb9f3333 -r da5f7e97958c src/arch/x86/bios/IntelMP.py > --- a/src/arch/x86/bios/IntelMP.py Fri Jan 30 20:04:57 2009 -0500 > +++ b/src/arch/x86/bios/IntelMP.py Sun Feb 01 16:59:34 2009 -0800 > @@ -115,9 +115,9 @@ > enable = Param.Bool(True, 'if this processor is usable') > bootstrap = Param.Bool(False, 'if this is the bootstrap processor') > > - stepping = Param.UInt8(0) > - model = Param.UInt8(0) > - family = Param.UInt8(0) > + stepping = Param.UInt8(0, 'Processor stepping') > + model = Param.UInt8(0, 'Processor model') > + family = Param.UInt8(0, 'Processor family') > > feature_flags = Param.UInt32(0, 'flags returned by the CPUID instruction') > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
