And in the end I missed a few anyways. Ah well. Gabe Black wrote: > changeset 2519ba935a5c in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=2519ba935a5c > description: > X86: Add some missing default arguments. > > diffstat: > > 3 files changed, 4 insertions(+), 2 deletions(-) > src/dev/x86/I8042.py | 2 ++ > src/dev/x86/I82094AA.py | 2 +- > src/dev/x86/I8259.py | 2 +- > > diffs (36 lines): > > diff -r 54f64fb1bd62 -r 2519ba935a5c src/dev/x86/I8042.py > --- a/src/dev/x86/I8042.py Sun Feb 01 17:09:08 2009 -0800 > +++ b/src/dev/x86/I8042.py Sun Feb 01 22:40:51 2009 -0800 > @@ -35,6 +35,8 @@ > type = 'I8042' > cxx_class = 'X86ISA::I8042' > pio_latency = Param.Latency('1ns', "Programmed IO latency in simticks") > + # This isn't actually used for anything here. > + pio_addr = 0x0 > data_port = Param.Addr('Data port address') > command_port = Param.Addr('Command/status port address') > mouse_int_pin = Param.X86IntSourcePin(X86IntSourcePin(), > diff -r 54f64fb1bd62 -r 2519ba935a5c src/dev/x86/I82094AA.py > --- a/src/dev/x86/I82094AA.py Sun Feb 01 17:09:08 2009 -0800 > +++ b/src/dev/x86/I82094AA.py Sun Feb 01 22:40:51 2009 -0800 > @@ -37,7 +37,7 @@ > pio_latency = Param.Latency('1ns', "Programmed IO latency in simticks") > pio_addr = Param.Addr("Device address") > int_port = Port("Port for sending and receiving interrupt messages") > - external_int_pic = Param.I8259("External PIC, if any") > + external_int_pic = Param.I8259(NULL, "External PIC, if any") > > def pin(self, line): > return X86IntSinkPin(device=self, number=line) > diff -r 54f64fb1bd62 -r 2519ba935a5c src/dev/x86/I8259.py > --- a/src/dev/x86/I8259.py Sun Feb 01 17:09:08 2009 -0800 > +++ b/src/dev/x86/I8259.py Sun Feb 01 22:40:51 2009 -0800 > @@ -44,7 +44,7 @@ > output = Param.X86IntSourcePin(X86IntSourcePin(), > 'The pin this I8259 drives') > mode = Param.X86I8259CascadeMode('How this I8259 is cascaded') > - slave = Param.I8259('Slave I8259, if any') > + slave = Param.I8259(NULL, 'Slave I8259, if any') > > def pin(self, line): > return X86IntSinkPin(device=self, number=line) > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
