> First important thing the tree fails to compile.  It seems that you
> forgot to commit arch/alpha/mt.hh (and maybe some other mt.hh files?)
> Please fix this ASAP!
Working on fixing this now..currently working in my tree, but
something's funky that it didnt show up in the main tree.

> My only major question is, should the InorderCPU now be
> defaulted to compile?  What ISAs does it work with now?  I see that
> you made it compile happily with o3, was there any other build issues?
It *should* compile with MIPS and ALPHA right now. I'm not sure what ISAs it
needs to compile for for it to be considered a default compile option.
As you noted,
the shared-branch prediction files were the only major build issues. Everything
else is encapsulated for the most part in that inorder directory. I had plans to
integrate some of the inner-working of the model into Python objects
(similar to how
O3 uses the Function Unit Pool as a object), but to simplify things I didnt
try to go too complicated too early.

> One final thing.  It's clear that you were using mercurial queues a
> lot.  I'm glad to see that.  One note is that after you qfold, you
> should update the commit message.
It seems that if you qfold multiple patches it adds the folded patch's message
to the end of the current patch's message. I thought that was a pretty
cool feature.
I probably forgot to add messages for some of the merges I didnt
intend to commit
originally.
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to