Derek, I'd like to request that you insert newlines such that your comments wrap at 80 columns.
Thanks, Nate On Wed, Jul 8, 2009 at 7:23 AM, Derek Hower<d...@cs.wisc.edu> wrote: > changeset 57650468aff1 in /z/repo/m5 > details: http://repo.m5sim.org/m5?cmd=changeset;node=57650468aff1 > description: > slicc: fixed MI_example bug. The directory wasn't deallocating the > TBE, leading to a leak. Also increased the default max TBE size to 256 to > allow memtest to pass the regression. > > diffstat: > > 2 files changed, 7 insertions(+), 7 deletions(-) > src/mem/protocol/MI_example-dir.sm | 12 ++++++------ > src/mem/ruby/config/defaults.rb | 2 +- > > diffs (82 lines): > > diff -r 553a34ccd03b -r 57650468aff1 src/mem/protocol/MI_example-dir.sm > --- a/src/mem/protocol/MI_example-dir.sm Wed Jul 08 00:34:40 2009 -0500 > +++ b/src/mem/protocol/MI_example-dir.sm Wed Jul 08 08:40:32 2009 -0500 > @@ -528,14 +528,15 @@ > > > transition(I, DMA_WRITE, ID_W) { > - dw_writeDMAData; > -// da_sendDMAAck; > + v_allocateTBE; > qw_queueMemoryWBRequest_partial; > p_popIncomingDMARequestQueue; > } > > transition(ID_W, Memory_Ack, I) { > + dwt_writeDMADataFromTBE; > da_sendDMAAck; > + w_deallocateTBE; > l_popMemQueue; > } > > @@ -548,7 +549,7 @@ > drp_sendDMAData; > c_clearOwner; > a_sendWriteBackAck; > - // d_deallocateDirectory; > + d_deallocateDirectory; > i_popIncomingRequestQueue; > } > > @@ -561,7 +562,6 @@ > transition(M_DWR, PUTX, M_DWRI) { > qw_queueMemoryWBRequest_partialTBE; > c_clearOwner; > - w_deallocateTBE; > i_popIncomingRequestQueue; > } > > @@ -570,6 +570,7 @@ > l_sendWriteBackAck; > da_sendDMAAck; > w_deallocateTBE; > + d_deallocateDirectory; > l_popMemQueue; > } > > @@ -583,7 +584,6 @@ > c_clearOwner; > v_allocateTBEFromRequestNet; > l_queueMemoryWBRequest; > - d_deallocateDirectory; > i_popIncomingRequestQueue; > } > > @@ -591,6 +591,7 @@ > w_writeDataToMemoryFromTBE; > l_sendWriteBackAck; > w_deallocateTBE; > + d_deallocateDirectory; > l_popMemQueue; > } > > @@ -601,7 +602,6 @@ > > transition(I, PUTX_NotOwner, I) { > b_sendWriteBackNack; > - d_deallocateDirectory; > i_popIncomingRequestQueue; > } > > diff -r 553a34ccd03b -r 57650468aff1 src/mem/ruby/config/defaults.rb > --- a/src/mem/ruby/config/defaults.rb Wed Jul 08 00:34:40 2009 -0500 > +++ b/src/mem/ruby/config/defaults.rb Wed Jul 08 08:40:32 2009 -0500 > @@ -12,7 +12,7 @@ > default_param :buffer_size, Integer, 32 > > # added by SS for TBE > - default_param :number_of_TBEs, Integer, 128 > + default_param :number_of_TBEs, Integer, 256 > > default_param :recycle_latency, Integer, 10 > end > _______________________________________________ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
