Confident that this fix is correct, that is. I just checked the diff of the older change and I did accidentally nuke an "=". If you're in a hurry please go ahead and commit this fix.
Gabe Quoting Gabriel Michael Black <[email protected]>: > This is actually my fault, I think. I changed around the code to use > BitUnions and I must have accidentally deleted an "=" here. I'm pretty > confident it's correct, but if you want to be sure you could look at > the diff of that change and see what the logic used to be. I'm a > little surprised that it failed to build for you since it seemed to > work fine as far as the regressions. Are you using a very new or old > compiler? > > Gabe > > Quoting nathan binkert <[email protected]>: > >> Korey, can you please comment on this? I'd like to commit a fix since >> I'm running a compiler that fails on this as well. >> >> Nate >> >> On Wed, Jul 29, 2009 at 2:48 PM, Vince Weaver<[email protected]> wrote: >>> Hello >>> >>> not sure if this is the proper place to send packages, but here it goes >>> >>> currently building for MIPS_SE fails. It looks like a = instead of a == >>> error, but the code is pretty dense so I can't tell if it's trying to be >>> overly clever. >>> >>> patch attached below. >>> >>> Vince >>> >>> diff -r b35ef789e6f6 src/arch/mips/mt.hh >>> --- a/src/arch/mips/mt.hh Wed Jul 29 00:35:49 2009 -0700 >>> +++ b/src/arch/mips/mt.hh Wed Jul 29 17:42:04 2009 -0400 >>> @@ -118,7 +118,7 @@ >>> tc->readRegOtherThread(MISCREG_TC_BIND + >>> Ctrl_Base_DepTag, tid); >>> TCBindReg tcBind = tc->readMiscRegNoEffect(MISCREG_TC_BIND); >>> >>> - if (tidTCBind.curVPE = tcBind.curVPE) { >>> + if (tidTCBind.curVPE == tcBind.curVPE) { >>> >>> TCStatusReg tidTCStatus = >>> tc->readRegOtherThread(MISCREG_TC_STATUS + >>> >>> _______________________________________________ >>> m5-dev mailing list >>> [email protected] >>> http://m5sim.org/mailman/listinfo/m5-dev >>> >>> >> _______________________________________________ >> m5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/m5-dev >> > > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
