Hi Tim, I've only skimmed this diff, but I have one comment and one question: 1) We don't want you doing a "using namespace std;" in a header file, but we're OK with it in a .cc file, so you can save yourself all of the std:: that you have. I'm not saying that you need to fix that, but in the future, you can do that if you want.
2) In a bunch of the generate disassembly stuff, you use both ccprintf and operator<< on a stringstream. Why did you use operator<<? Did ccprintf not work? I'm just curious. Nate On Thu, Oct 8, 2009 at 7:37 AM, Timothy M. Jones <[email protected]> wrote: > # HG changeset patch > # User Timothy Jones > # Date 1255004888 -3600 > # Node ID 4b6b39589edfceea071214a718bc2492bbc23b5a > # Parent b5bcd4a7b0bc76251fad360f959a3b2d42c805e3 > Add support for the PowerPC ISA. > This adds support for the 32-bit, big endian PowerPC ISA. This supports both > integer and floating point instructions based on the Power ISA Book I v2.06. _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
