This looks fine and I'll commit it. One thing that would be nice, though, is if you put a short tag at the beginning of the first line of your patch. This way, if someone is looking through changesets, they can easily see what affected what. For this patch, I'd use X86, for some of your others maybe Syscall. There isn't an official set of choices, and as long as it's short, reasonable, and a little consistent that would be great. I've adjust this patch below. The tags aren't mandatory, but it's a nice habit to be in.
Gabe Vince Weaver wrote: > This is a straightforward patch. Attached are two test cases showing it > works. The x86-64 test case will fail if time is called via the vsyscall > page; a fix for that will follow shortly. > > Vince > > # HG changeset patch > # User Vince Weaver <[email protected]> > # Date 1257311955 18000 > # Node ID fd81a6260f2e758c8e0a1bef13a935351648ca83 > # Parent 0e5037cecaf776e18a6be727981a33144f4bde64 > X86: hook up time syscall on X86 > > this has been tested and verified that it works. > > diff -r 0e5037cecaf7 -r fd81a6260f2e src/arch/x86/linux/syscalls.cc > --- a/src/arch/x86/linux/syscalls.cc Fri Oct 30 12:49:37 2009 -0400 > +++ b/src/arch/x86/linux/syscalls.cc Wed Nov 04 00:19:15 2009 -0500 > @@ -432,7 +432,7 @@ > /* 198 */ SyscallDesc("lremovexattr", unimplementedFunc), > /* 199 */ SyscallDesc("fremovexattr", unimplementedFunc), > /* 200 */ SyscallDesc("tkill", unimplementedFunc), > - /* 201 */ SyscallDesc("time", unimplementedFunc), > + /* 201 */ SyscallDesc("time", timeFunc<X86Linux64>), > /* 202 */ SyscallDesc("futex", ignoreFunc), > /* 203 */ SyscallDesc("sched_setaffinity", unimplementedFunc), > /* 204 */ SyscallDesc("sched_getaffinity", unimplementedFunc), > @@ -523,7 +523,7 @@ > /* 10 */ SyscallDesc("unlink", unimplementedFunc), > /* 11 */ SyscallDesc("execve", unimplementedFunc), > /* 12 */ SyscallDesc("chdir", unimplementedFunc), > - /* 13 */ SyscallDesc("time", unimplementedFunc), > + /* 13 */ SyscallDesc("time", timeFunc<X86Linux32>), > /* 14 */ SyscallDesc("mknod", unimplementedFunc), > /* 15 */ SyscallDesc("chmod", unimplementedFunc), > /* 16 */ SyscallDesc("lchown", unimplementedFunc), > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
