I just sent out the destructor patch. I tried to reproduce the seg fault, but instead I encountered the not scheduled assertion (see below). Actually this is the common problem I encountered with calling the sim_object destructors on sim_exit. I fixed some of these problems with my patches, but I'm sure many still exist since it is dependent on what code and events you schedule.
m5.debug: /tmp/bbeckman/m5/build/ALPHA_SE_MOESI_CMP_token/sim/eventq.cc:62: virtual Event::~Event(): Assertion `!scheduled()' failed. Brad -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of nathan binkert Sent: Thursday, November 19, 2009 6:44 PM To: M5 Developer List Subject: Re: [m5-dev] changeset in m5: m5: removed master and slavedeletions. Sure. Just post the patch here. Be interesting to try to clean some of that stuff up. Nate On Thu, Nov 19, 2009 at 4:07 PM, Beckmann, Brad <[email protected]> wrote: > All of these destructor fixes were problems I encountered when I called all > the sim_object destructors on M5 exit. (I can send you the simple patch if > you like.) > > I'll send out details on the specific error later today. > > Brad > > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > nathan binkert > Sent: Wednesday, November 18, 2009 8:30 PM > To: M5 Developer List > Subject: Re: [m5-dev] changeset in m5: m5: removed master and slavedeletions. > > Can you explain this error better? When did it come up? I'd rather > fix the problem rather than just cover it up. > > Nate > > On Wed, Nov 18, 2009 at 6:05 PM, Brad Beckmann <[email protected]> wrote: >> changeset 62c628499cd4 in /z/repo/m5 >> details: http://repo.m5sim.org/m5?cmd=changeset;node=62c628499cd4 >> description: >> m5: removed master and slave deletions. >> The unresolved destructor call caused a seg fault when called. >> >> diffstat: >> >> 1 file changed, 2 deletions(-) >> src/dev/ide_ctrl.cc | 2 -- >> >> diffs (12 lines): >> >> diff -r 788cdecedf9f -r 62c628499cd4 src/dev/ide_ctrl.cc >> --- a/src/dev/ide_ctrl.cc Wed Nov 18 13:55:58 2009 -0800 >> +++ b/src/dev/ide_ctrl.cc Wed Nov 18 13:55:58 2009 -0800 >> @@ -75,8 +75,6 @@ >> >> IdeController::Channel::~Channel() >> { >> - delete master; >> - delete slave; >> } >> >> IdeController::IdeController(Params *p) >> _______________________________________________ >> m5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/m5-dev >> >> > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
