> # HG changeset patch > # User Brad Beckmann <[email protected]> > # Date 1260657435 28800 > # Node ID 05140b07714b6f591b3f511b7a3f076aae3d756b > # Parent 2811007a9adc2edc51fdd303909662a852186d52
> diff -r 2811007a9adc -r 05140b07714b src/mem/protocol/MOESI_hammer-cache.sm > --- a/src/mem/protocol/MOESI_hammer-cache.sm Sat Dec 12 14:37:15 2009 -0800 > +++ b/src/mem/protocol/MOESI_hammer-cache.sm Sat Dec 12 14:37:15 2009 -0800 > - Sequencer sequencer, > factory='RubySystem::getSequencer(m_cfg["sequencer"])'; > + //Sequencer sequencer, > factory='RubySystem::getSequencer(m_cfg["sequencer"])'; Don't comment out code. > diff -r 2811007a9adc -r 05140b07714b src/mem/protocol/RubySlicc_Types.sm > --- a/src/mem/protocol/RubySlicc_Types.sm Sat Dec 12 14:37:15 2009 -0800 > +++ b/src/mem/protocol/RubySlicc_Types.sm Sat Dec 12 14:37:15 2009 -0800 > @@ -119,3 +143,5 @@ > } > > > + > + Please remove this random whitespace change. > diff -r 2811007a9adc -r 05140b07714b > src/mem/ruby/slicc_interface/AbstractEntry.cc > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/src/mem/ruby/slicc_interface/AbstractEntry.cc Sat Dec 12 14:37:15 > 2009 -0800 > @@ -0,0 +1,45 @@ > + > +/* > + * Copyright (c) 1999-2008 Mark D. Hill and David A. Wood Shouldn't this just be AMD? or was this moved? > +/* > + * $Id$ > + * > + * Description: See AbstractCacheEntry.hh > + * > + */ Please don't add this comment. It is more or less just useless > diff -r 2811007a9adc -r 05140b07714b > src/mem/ruby/slicc_interface/AbstractEntry.hh > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/src/mem/ruby/slicc_interface/AbstractEntry.hh Sat Dec 12 14:37:15 > 2009 -0800 > @@ -0,0 +1,80 @@ > + > +/* > + * Copyright (c) 1999-2008 Mark D. Hill and David A. Wood > + * All rights reserved. Again. AMD? > +/* > + * $Id$ > + * > + * Description: Common base class for a machine node. > + * > + */ Please remove the $Id$. It doesn't mean anything in hg. > diff -r 2811007a9adc -r 05140b07714b src/mem/slicc/ast/StaticCastAST.py > --- /dev/null Thu Jan 01 00:00:00 1970 +0000 > +++ b/src/mem/slicc/ast/StaticCastAST.py Sat Dec 12 14:37:15 2009 -0800 > @@ -0,0 +1,51 @@ > +# Copyright (c) 1999-2008 Mark D. Hill and David A. Wood > +# Copyright (c) 2009 The Hewlett-Packard Development Company Is this copied from somewhere? If so, please use "hg cp" instead of just cp. If it is not copied, please fix the copyright. _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
