Sorry Nate, That was from a while ago and wasn't meant to be committed. I take the blame.
Polina On Sat, Jan 23, 2010 at 12:31 PM, nathan binkert <[email protected]> wrote: > I was about to commit my change to the style hook, but I just wasted > two hours trying to figure out why my fix was no longer working until > I realized that the following patch existed. Please don't ever commit > a changeset that simply disables code in this sort of manner. At the > minimum, if you disable code that should be fixed, a warning of some > sort should be printed so that we know that the code has been > disabled. > > I know that I should have fixed this a long time ago, but I didn't > really know what the problem was until I upgraded to a newer version > of mercurial myself and since you never said anything about it again, > I assumed that you had figured it out. > > In the future, this is something that should either be flagged as a > critical fix or such a patch should be in your personal queue. Also, > if you do put something like this in your queue, please don't bury it > in another unrelated changeset. If this were a standalone changeset > with a commit message like "disabling style hook", I would have > noticed it. > > Nate > > > diff -r f9e065561d5c -r 104115ebc206 util/style.py > > --- a/util/style.py Mon Aug 17 11:33:32 2009 -0500 > > +++ b/util/style.py Fri Aug 21 15:52:46 2009 -0500 > > @@ -65,7 +65,7 @@ > > if filename.startswith("SCons"): > > return True > > > > - return False > > + return True > > > > format_types = ( 'C', 'C++' ) > > def format_file(filename): > > @@ -77,11 +77,11 @@ > > def checkwhite_line(line): > > match = lead.search(line) > > if match and match.group(1).find('\t') != -1: > > - return False > > + return True > > > > match = trail.search(line) > > if match: > > - return False > > + return True > > > > return True > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
