> Your diff looks fine to me.  Initially I was confused why you needed to add 
> the double colon as part of a type, but I now realize this doesn't change the 
> protocol specifications files at all.  It simply allows the LiteralExprAST to 
> generate the string type identifier as 'std::string' instead of 'string'.  As 
> long as it doesn't impact the specification files, it is fine by me.

True, I wanted it for the LiteralExprAST, but that's not quite
everything.  I also needed to allow std::string anywhere that you'd
use a type (such as the return value of a function (e.g. getStateStr
or getCoherenceRequestTypeStr), so the way I did it allows all types
to have :: in them.  Meaning that you could now (in a limited manner)
use namespaces in ruby.  All in all, it seems like it's only a plus to
me.

Thanks for taking a look.

  Nate
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to