----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/16/#review4 -----------------------------------------------------------
This change is pretty close to ok. If you fix up the things mentioned below, it should be ready to go. I'd want to look at it one last time to be sure, though. src/base/loader/elf_object.cc <http://reviews.m5sim.org/r/16/#comment34> Remove this comment. src/base/loader/elf_object.cc <http://reviews.m5sim.org/r/16/#comment36> This change is unnecessary and actually breaks M5 style guidelines. src/base/loader/elf_object.cc <http://reviews.m5sim.org/r/16/#comment35> I don't think you need to change the whitespace here. src/base/loader/object_file.hh <http://reviews.m5sim.org/r/16/#comment37> Remove this comment. - Gabe On 2010-04-28 18:43:25, Gou Pengfei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/16/ > ----------------------------------------------------------- > > (Updated 2010-04-28 18:43:25) > > > Review request for Default, Ali Saidi and Nathan Binkert. > > > Summary > ------- > > Some trivial changes. > > > Diffs > ----- > > src/base/loader/elf_object.cc edde97a6ea7c > src/base/loader/object_file.hh edde97a6ea7c > > Diff: http://reviews.m5sim.org/r/16/diff > > > Testing > ------- > > Can load binaries generated by TRIPS toolchain. > > > Thanks, > > Gou > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
