----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/6/#review10 -----------------------------------------------------------
How about giving this method a more meaningful name instead of just overloading insert()? The name doesn't give you any clues on what that second event is for; if you had to guess, you'd think maybe there was a need to insert pairs of events simultaneously. How about insertNear()? - Steve On 2010-04-18 22:43:58, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/6/ > ----------------------------------------------------------- > > (Updated 2010-04-18 22:43:58) > > > Review request for Default. > > > Summary > ------- > > eventq: add a version of insert that takes a hint > This hint is in the form of another event that has the same tick and > priority. If the hint is wrong, then the normal schedule happens, but > if the hint is right, the insertion is O(1). This version is also > inlined so if the hint is good, it's pretty darned fast. > > > Diffs > ----- > > src/sim/eventq.hh edde97a6ea7c > > Diff: http://reviews.m5sim.org/r/6/diff > > > Testing > ------- > > > Thanks, > > Nathan > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
