----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/23/#review41 -----------------------------------------------------------
Ship it! Looks fine to me. - Nilay On 2010-06-02 15:56:45, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/23/ > ----------------------------------------------------------- > > (Updated 2010-06-02 15:56:45) > > > Review request for Ruby Reviewers. > > > Summary > ------- > > ruby: get rid of the Map class > > > Diffs > ----- > > src/base/hashmap.hh be2acdfb8bdc > src/base/stl_helpers.hh PRE-CREATION > src/cpu/rubytest/CheckTable.hh be2acdfb8bdc > src/cpu/rubytest/CheckTable.cc be2acdfb8bdc > src/mem/gems_common/Map.hh be2acdfb8bdc > src/mem/ruby/filters/BlockBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/BulkBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/H3BloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/LSB_CountingBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/MultiBitSelBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/MultiGrainBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/NonCountingBloomFilter.cc be2acdfb8bdc > src/mem/ruby/network/simple/SimpleNetwork.cc be2acdfb8bdc > src/mem/ruby/profiler/AccessTraceForAddress.hh be2acdfb8bdc > src/mem/ruby/profiler/AccessTraceForAddress.cc be2acdfb8bdc > src/mem/ruby/profiler/AddressProfiler.hh be2acdfb8bdc > src/mem/ruby/profiler/AddressProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/CacheProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/Profiler.hh be2acdfb8bdc > src/mem/ruby/profiler/Profiler.cc be2acdfb8bdc > src/mem/ruby/system/MemoryControl.hh be2acdfb8bdc > src/mem/ruby/system/MemoryControl.cc be2acdfb8bdc > src/mem/ruby/system/PerfectCacheMemory.hh be2acdfb8bdc > src/mem/ruby/system/PersistentTable.hh be2acdfb8bdc > src/mem/ruby/system/PersistentTable.cc be2acdfb8bdc > src/mem/ruby/system/Sequencer.hh be2acdfb8bdc > src/mem/ruby/system/Sequencer.cc be2acdfb8bdc > src/mem/ruby/system/TBETable.hh be2acdfb8bdc > src/mem/ruby/system/TimerTable.hh be2acdfb8bdc > src/mem/ruby/system/TimerTable.cc be2acdfb8bdc > > Diff: http://reviews.m5sim.org/r/23/diff > > > Testing > ------- > > All regressions pass > > > Thanks, > > Nathan > > _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
