----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/24/#review48 -----------------------------------------------------------
Overall this patch looks good. However before pushing it, Tushar and I want to talk about some outstanding changes we have to Garnet. I'll send you a separate note on that. - Brad On 2010-06-02 15:56:55, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/24/ > ----------------------------------------------------------- > > (Updated 2010-06-02 15:56:55) > > > Review request for Ruby Reviewers. > > > Summary > ------- > > ruby: get rid of PrioHeap and use STL > > One big difference is that PrioHeap puts the smallest element at the > top of the heap, whereas stl puts the largest element on top, so I > changed all comparisons so they did the right thing. > > Some usage of PrioHeap was simply changed to a std::vector, using sort > at the right time, other usage had me just use the various heap functions > in the stl. > > > Diffs > ----- > > src/mem/gems_common/PrioHeap.hh be2acdfb8bdc > src/mem/ruby/buffers/MessageBuffer.hh be2acdfb8bdc > src/mem/ruby/buffers/MessageBuffer.cc be2acdfb8bdc > src/mem/ruby/buffers/MessageBufferNode.hh be2acdfb8bdc > src/mem/ruby/common/NetDest.cc be2acdfb8bdc > src/mem/ruby/eventqueue/RubyEventQueue.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/flit.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.cc be2acdfb8bdc > src/mem/ruby/profiler/AccessTraceForAddress.hh be2acdfb8bdc > src/mem/ruby/profiler/AddressProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/CacheProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/Profiler.cc be2acdfb8bdc > src/mem/ruby/recorder/CacheRecorder.hh be2acdfb8bdc > src/mem/ruby/recorder/CacheRecorder.cc be2acdfb8bdc > src/mem/ruby/recorder/TraceRecord.hh be2acdfb8bdc > src/mem/ruby/recorder/Tracer.hh be2acdfb8bdc > src/mem/ruby/recorder/Tracer.cc be2acdfb8bdc > > Diff: http://reviews.m5sim.org/r/24/diff > > > Testing > ------- > > All regressions pass > > > Thanks, > > Nathan > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
