----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/25/#review51 -----------------------------------------------------------
Ship it! Assuming that it compiles and passes regressions. - Nathan On 2010-06-27 21:27:49, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/25/ > ----------------------------------------------------------- > > (Updated 2010-06-27 21:27:49) > > > Review request for Default. > > > Summary > ------- > > sim: fold StartupCallback into SimObject > There used to be a reason to have StartupCallback > be a separate object, but not any more. Now > it's just confusing. > > > Diffs > ----- > > src/base/cp_annotate.hh 5044bb906d5a > src/python/m5/simulate.py 5044bb906d5a > src/python/swig/core.i 5044bb906d5a > src/python/swig/pyobject.hh 5044bb906d5a > src/sim/SConscript 5044bb906d5a > src/sim/sim_events.cc 5044bb906d5a > src/sim/sim_object.hh 5044bb906d5a > src/sim/sim_object.cc 5044bb906d5a > src/sim/startup.hh 5044bb906d5a > src/sim/startup.cc 5044bb906d5a > > Diff: http://reviews.m5sim.org/r/25/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
