----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/51/#review65 -----------------------------------------------------------
src/cpu/base.cc <http://reviews.m5sim.org/r/51/#comment202> Is there a reason to allocate this dynamically instead of having a single static counter per CPU object? src/sim/eventq.hh <http://reviews.m5sim.org/r/51/#comment203> I don't like getting rid of this assertion... it's actually pretty useful in knowing when something's not right. You should add some code upstream somewhere to skip adding the event if we're already past it. src/sim/sim_object.cc <http://reviews.m5sim.org/r/51/#comment204> I'd prefer a more informative message like "Error: setMaxInsts called on non-CPU" (and same with the following function). There's a broader question of whether this is how we want to expose subclass-specific methods to Python... I don't have any great ideas for alternatives, but Nate might. - Steve On 2010-07-09 18:14:44, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/51/ > ----------------------------------------------------------- > > (Updated 2010-07-09 18:14:44) > > > Review request for Default. > > > Summary > ------- > > CPU: Add functions to get the number of executed instructions and set the > maximum number of instructions to execute to the CPUs and allow them to be > called from python. > > > Diffs > ----- > > src/cpu/BaseCPU.py 249f174e6f37 > src/cpu/base.hh 249f174e6f37 > src/cpu/base.cc 249f174e6f37 > src/cpu/o3/cpu.hh 249f174e6f37 > src/cpu/simple/base.hh 249f174e6f37 > src/python/swig/sim_object.i 249f174e6f37 > src/sim/eventq.hh 249f174e6f37 > src/sim/sim_object.hh 249f174e6f37 > src/sim/sim_object.cc 249f174e6f37 > > Diff: http://reviews.m5sim.org/r/51/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
