On Fri, Jul 16, 2010 at 7:03 PM, Timothy M Jones <[email protected]> wrote: > Hi everyone, > > As you'll have seen, I've made some updates to the reviews I posted recently > to help implement SMARTS. I'd like to commit the trivial ones towards the > end of next week, if no-one objects. These are: > > http://reviews.m5sim.org/r/35/ > http://reviews.m5sim.org/r/50/ > http://reviews.m5sim.org/r/52/ > http://reviews.m5sim.org/r/54/ > http://reviews.m5sim.org/r/55/ > http://reviews.m5sim.org/r/58/
These look fine to me. > I'd like to commit this too, if people are happy with the fix: > > http://reviews.m5sim.org/r/49/ Give me a little bit to think about this one... > This one I'm going to wait for Steve to push his patch for > SimObject.__getattr__ that I can take advantage of: > > http://reviews.m5sim.org/r/53/ Done. > This one I'm working on adding a pointer into the event queue to the > variable that should be used as a comparison. I'm also going to move the > python methods out of SimObject and let swig wrap the BaseCPU. I think > that's what was agreed from reading the comments, right? > > http://reviews.m5sim.org/r/51/ That's what I got out of our discussion too... > Does that sound ok to everyone? Sounds great... thanks for being so accommodating. Steve _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
