----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/76/#review124 -----------------------------------------------------------
Ship it! - Ali On 2010-07-29 21:51:41, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/76/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:51:41) > > > Review request for Default. > > > Summary > ------- > > bus: clean up default responder code. > Clean up some minor things left over from the default responder > change in rev 9af6fb59752f. Mostly renaming the 'responder_set' > param to 'use_default_range' to actually reflect what it does... > old name wasn't that descriptive in the first place, but now > it really doesn't make sense at all. > > Also got rid of the bogus obsolete assignment to 'bus.responder' > which used to be a parameter but now is interpreted as an > implicit child assignment, and which was giving me problems in > the config restructuring to come. (A good argument for not > allowing implicit child assignments, IMO, but that's water under > the bridge, I'm afraid.) > > Also moved the Bus constructor to the .cc file since that's > where it should have been all along. > > > Diffs > ----- > > src/dev/alpha/Tsunami.py b28e7286990c > src/dev/x86/Pc.py b28e7286990c > src/mem/Bus.py b28e7286990c > src/mem/bus.hh b28e7286990c > src/mem/bus.cc b28e7286990c > > Diff: http://reviews.m5sim.org/r/76/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
