----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/75/#review127 -----------------------------------------------------------
Ship it! - Nathan On 2010-07-29 21:51:31, Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/75/ > ----------------------------------------------------------- > > (Updated 2010-07-29 21:51:31) > > > Review request for Default. > > > Summary > ------- > > sim: fail on implicit creation of orphans via ports > Orphan SimObjects (not in the config hierarchy) could get > created implicitly if they have a port connection to a SimObject > that is in the hierarchy. This means that there are objects on > the C++ SimObject list (created via the C++ SimObject > constructor call) that are unknown to Python and will get > skipped if we walk the hierarchy from the Python side (as we are > about to do). This patch detects this situation and prints an > error message. > > Also fix the rubytester config script which happened to rely on > this behavior. > > > Diffs > ----- > > src/python/m5/SimObject.py b28e7286990c > src/python/m5/params.py b28e7286990c > tests/configs/rubytest-ruby.py b28e7286990c > > Diff: http://reviews.m5sim.org/r/75/diff > > > Testing > ------- > > > Thanks, > > Steve > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
