----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/88/#review137 -----------------------------------------------------------
src/mem/ruby/network/Network.py <http://reviews.m5sim.org/r/88/#comment276> name conflicts with SimObject::name. I think you're going to have to pick a different word. Also, is this string purely to allow the user to annotate things? If so, couldn't the user just name the object more appropriately? - Nathan On 2010-08-05 21:43:11, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/88/ > ----------------------------------------------------------- > > (Updated 2010-08-05 21:43:11) > > > Review request for Default. > > > Summary > ------- > > config: Added the topology name to m5 & ruby output > > > Diffs > ----- > > configs/ruby/Ruby.py a75564db03c3 > src/mem/ruby/network/Network.py a75564db03c3 > src/mem/ruby/network/simple/Topology.cc a75564db03c3 > > Diff: http://reviews.m5sim.org/r/88/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
