----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/89/#review138 -----------------------------------------------------------
configs: is probably a better keyword. configs/ruby/MOESI_CMP_directory.py <http://reviews.m5sim.org/r/89/#comment277> I know that you're just trying to follow the 80 column rule here, but the idea when you go over 80 columns is to try to create temporary variables. something like: dir = RubyDirectoryMemory(...) dir_cntrl = Directory_Controller(version=i, directory=dir, etc. - Nathan On 2010-08-05 21:43:25, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/89/ > ----------------------------------------------------------- > > (Updated 2010-08-05 21:43:25) > > > Review request for Default. > > > Summary > ------- > > ruby: Improve ruby simobject names > > This patch attaches ruby objects to the system before the topology is > created so that their simobject names read their meaningful variable > names instead of their topology name. > > > Diffs > ----- > > configs/example/ruby_fs.py a75564db03c3 > configs/example/ruby_se.py a75564db03c3 > configs/example/rubytest.py a75564db03c3 > configs/ruby/MESI_CMP_directory.py PRE-CREATION > configs/ruby/MI_example.py PRE-CREATION > configs/ruby/MOESI_CMP_directory.py PRE-CREATION > configs/ruby/MOESI_CMP_token.py PRE-CREATION > configs/ruby/MOESI_hammer.py PRE-CREATION > configs/ruby/Ruby.py a75564db03c3 > > Diff: http://reviews.m5sim.org/r/89/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
