----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/101/#review148 -----------------------------------------------------------
I think the directory name needs to have tester in it. src/cpu/deterministic gives you no indication of what it actually is. Beyond that, is it really necessary to have multiple testers? Can we not fold the functionality into a single tester? src/cpu/deterministic/DetermGenerator.hh <http://reviews.m5sim.org/r/101/#comment285> These include guards need to be fixed. src/cpu/deterministic/DetermGenerator.hh <http://reviews.m5sim.org/r/101/#comment286> Sort includes please. src/cpu/deterministic/DetermGenerator.hh <http://reviews.m5sim.org/r/101/#comment287> All of the comments in this file are pretty obvious and should probably be deleted. src/cpu/deterministic/DetermGenerator.hh <http://reviews.m5sim.org/r/101/#comment290> For new files, can you please follow the M5 style for variable names? no m_ and camelCase. src/cpu/deterministic/InvalidateGenerator.hh <http://reviews.m5sim.org/r/101/#comment288> Fix include guards src/cpu/deterministic/InvalidateGenerator.hh <http://reviews.m5sim.org/r/101/#comment289> Useless comments. src/cpu/deterministic/InvalidateGenerator.cc <http://reviews.m5sim.org/r/101/#comment291> You don't need to change this if you don't want to, but for your education, you could simply collapse this line and the next into: uint8_t *dummyData = new uint8_t(0); src/cpu/deterministic/RubyDetermTester.cc <http://reviews.m5sim.org/r/101/#comment292> Please just delete this comment. src/cpu/deterministic/SeriesRequestGenerator.hh <http://reviews.m5sim.org/r/101/#comment293> Fix include guards. src/cpu/deterministic/SeriesRequestGenerator.hh <http://reviews.m5sim.org/r/101/#comment295> useless comments src/cpu/deterministic/SeriesRequestGenerator.hh <http://reviews.m5sim.org/r/101/#comment294> Fix variable names. - Nathan On 2010-08-05 21:50:45, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/101/ > ----------------------------------------------------------- > > (Updated 2010-08-05 21:50:45) > > > Review request for Default. > > > Summary > ------- > > ruby: Resurrected Ruby's deterministic tests > > Added the request series and invalidate deterministic tests as new cpu models > and removed the no longer needed ruby tests > > > Diffs > ----- > > configs/example/determ_test.py PRE-CREATION > src/cpu/deterministic/DetermGenerator.hh PRE-CREATION > src/cpu/deterministic/DetermGenerator.cc PRE-CREATION > src/cpu/deterministic/InvalidateGenerator.hh PRE-CREATION > src/cpu/deterministic/InvalidateGenerator.cc PRE-CREATION > src/cpu/deterministic/RubyDetermTester.hh PRE-CREATION > src/cpu/deterministic/RubyDetermTester.cc PRE-CREATION > src/cpu/deterministic/RubyDetermTester.py PRE-CREATION > src/cpu/deterministic/SConscript PRE-CREATION > src/cpu/deterministic/SeriesRequestGenerator.hh PRE-CREATION > src/cpu/deterministic/SeriesRequestGenerator.cc PRE-CREATION > src/mem/protocol/RubySlicc_Exports.sm a75564db03c3 > src/mem/ruby/tester/DetermGETXGenerator.hh a75564db03c3 > src/mem/ruby/tester/DetermGETXGenerator.cc a75564db03c3 > src/mem/ruby/tester/DetermInvGenerator.hh a75564db03c3 > src/mem/ruby/tester/DetermInvGenerator.cc a75564db03c3 > src/mem/ruby/tester/DetermSeriesGETSGenerator.hh a75564db03c3 > src/mem/ruby/tester/DetermSeriesGETSGenerator.cc a75564db03c3 > src/mem/ruby/tester/SConscript a75564db03c3 > > Diff: http://reviews.m5sim.org/r/101/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
