----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/109/#review149 -----------------------------------------------------------
src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/109/#comment296> What's the point of this status flag? src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/109/#comment297> Why not just return false here. src/mem/ruby/system/Sequencer.cc <http://reviews.m5sim.org/r/109/#comment298> and return true here. - Nathan On 2010-08-05 21:52:42, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/109/ > ----------------------------------------------------------- > > (Updated 2010-08-05 21:52:42) > > > Review request for Default. > > > Summary > ------- > > ruby: Added SC fail indication to trace profiling > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.hh a75564db03c3 > src/mem/ruby/system/Sequencer.cc a75564db03c3 > > Diff: http://reviews.m5sim.org/r/109/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
