Please disregard my previous question. I just noticed that 'hg postreview' has a '-e' option where one can specify an existing review id to update. It requires one to identify the review id for every patch, but it is much better than manually uploading patches.
Brad From: [email protected] [mailto:[email protected]] On Behalf Of Beckmann, Brad Sent: Wednesday, August 11, 2010 10:15 AM To: M5 Developer List Subject: Re: [m5-dev] Ruby Patches I've addressed Nate's comments and I have a set of patch updates to post for review. I noticed that 'hg postreview' won't update the current patch but instead will create new patches. I see that I can manually update the patches on the reviewboard website, but for the number of patches I want to update, that is rather tedious. Can anyone recommend a better method, or am I suck manually updating the patches through the website? Thanks, Brad From: [email protected] [mailto:[email protected]] On Behalf Of Dan Gibson Sent: Monday, August 09, 2010 5:57 AM To: M5 Developer List Subject: Re: [m5-dev] Ruby Patches I recommend Derek, as Polina is away on internship. Regards, Dan On Sun, Aug 8, 2010 at 9:58 PM, nathan binkert <[email protected]<mailto:[email protected]>> wrote: Hi Brad, I quickly skimmed the ruby patches, though I didn't do any "Ship It" comments because I'm really not qualified to review them. There is a "Ruby" group in reviewboard, and I suggest that you change your patches to use it so that it will include Polina and Derek in your requests (or at least send them an e-mail and ask them to review your changes.) Nate _______________________________________________ m5-dev mailing list [email protected]<mailto:[email protected]> http://m5sim.org/mailman/listinfo/m5-dev -- http://www.cs.wisc.edu/~gibson [esc]:wq!
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
