Yep...that is the issue. BTW, I did use "hg mv" for this patch.
Brad -----Original Message----- From: Nathan Binkert [mailto:[email protected]] Sent: Wednesday, August 11, 2010 7:54 PM To: Default; Beckmann, Brad; Nathan Binkert Subject: Re: Review Request: ruby: moved python protocol files > On 2010-08-08 08:13:16, Nathan Binkert wrote: > > I think you should make it clear in the commit message that you moved the > > protocol files for the configuration. (I assumed src/mem/protocol). Also, > > did you use "hg mv" for this? The diff doesn't show that, but that could > > be reviewboard screwing it up. Ok, are you updating commit messages, but the updates aren't making it into reviewboard? - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/85/#review135 ----------------------------------------------------------- On 2010-08-11 14:36:58, Brad Beckmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/85/ > ----------------------------------------------------------- > > (Updated 2010-08-11 14:36:58) > > > Review request for Default. > > > Summary > ------- > > ruby: moved python protocol files > > Moved the python protocol files back to their original location to avoid > addToPath calls. > > > Diffs > ----- > > configs/ruby/MESI_CMP_directory.py PRE-CREATION > configs/ruby/MI_example.py PRE-CREATION > configs/ruby/MOESI_CMP_directory.py PRE-CREATION > configs/ruby/MOESI_CMP_token.py PRE-CREATION > configs/ruby/MOESI_hammer.py PRE-CREATION > configs/ruby/Ruby.py a75564db03c3 > configs/ruby/protocols/MESI_CMP_directory.py a75564db03c3 > configs/ruby/protocols/MI_example.py a75564db03c3 > configs/ruby/protocols/MOESI_CMP_directory.py a75564db03c3 > configs/ruby/protocols/MOESI_CMP_token.py a75564db03c3 > configs/ruby/protocols/MOESI_hammer.py a75564db03c3 > > Diff: http://reviews.m5sim.org/r/85/diff > > > Testing > ------- > > > Thanks, > > Brad > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
