----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/168/#review178 -----------------------------------------------------------
src/arch/arm/isa.cc <http://reviews.m5sim.org/r/168/#comment320> These could stand to be bitunions and constructed by assigning values to their bitfields this would be a lot less opaque, easier to change, and wouldn't require comments that can wander out of sync. I realize this isn't within the scope of this change necessarily, but since you're touching this code it would be nice to fix it up. It could be put in a new patch to keep them more atomic. - Gabe On 2010-08-13 10:07:44, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/168/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:07:44) > > > Review request for Default. > > > Summary > ------- > > ARM: We don't currently support ThumbEE exceptions, so don't report that we do > > > Diffs > ----- > > src/arch/arm/isa.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/168/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
