----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/191/#review189 -----------------------------------------------------------
src/arch/arm/isa/templates/mem.isa <http://reviews.m5sim.org/r/191/#comment329> These aren't in completeAcc, so the changeset description needs adjusting. You could move that line before the write since you have the write data by then, but I think write() is already calling setData for you so it's really just not necessary. That means you're probably doubly right to remove it. - Gabe On 2010-08-13 10:15:01, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/191/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:15:01) > > > Review request for Default. > > > Summary > ------- > > ARM: Don't write tracedata in completeAcc as we might have freed it already > > > Diffs > ----- > > src/arch/arm/isa/templates/mem.isa 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/191/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
