----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/195/#review192 -----------------------------------------------------------
src/arch/arm/isa.hh <http://reviews.m5sim.org/r/195/#comment333> This is doing extra work for all miscregs when only the SPSR is affected. This should be a function just for picking the right SPSR index and only called when the SPSR is accessed, basically just exporting the switch statement in the original code into a function. - Gabe On 2010-08-13 10:16:56, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/195/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:16:56) > > > Review request for Default. > > > Summary > ------- > > ARM: Clean up flattening for SPSR adding > > > Diffs > ----- > > src/arch/arm/isa.hh 3c48b2b3cb83 > src/arch/arm/isa.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/195/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
