----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/160/#review230 -----------------------------------------------------------
Seems reasonable. How does the mask work and why is it different for two different OSes? Can you add a better comment somewhere? - Nathan On 2010-08-13 09:42:08, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/160/ > ----------------------------------------------------------- > > (Updated 2010-08-13 09:42:08) > > > Review request for Default. > > > Summary > ------- > > Loader: Make the load address mask be a parameter of the system rather than a > constant. This allows one two different OS requirements for the same ISA to > be handled. > > > Diffs > ----- > > src/arch/alpha/AlphaSystem.py 3c48b2b3cb83 > src/arch/alpha/isa_traits.hh 3c48b2b3cb83 > src/arch/alpha/system.cc 3c48b2b3cb83 > src/arch/arm/ArmSystem.py 3c48b2b3cb83 > src/arch/arm/isa_traits.hh 3c48b2b3cb83 > src/arch/mips/MipsSystem.py 3c48b2b3cb83 > src/arch/mips/isa_traits.hh 3c48b2b3cb83 > src/arch/mips/system.cc 3c48b2b3cb83 > src/arch/sparc/SparcSystem.py 3c48b2b3cb83 > src/arch/sparc/isa_traits.hh 3c48b2b3cb83 > src/arch/x86/X86System.py 3c48b2b3cb83 > src/arch/x86/isa_traits.hh 3c48b2b3cb83 > src/sim/System.py 3c48b2b3cb83 > src/sim/system.hh 3c48b2b3cb83 > src/sim/system.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/160/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
