----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/167/#review236 -----------------------------------------------------------
Ship it! Looks fine. Why do all of the files show up as new in reviewboard? Are you using the -o option to hg postreview? - Nathan On 2010-08-13 10:07:17, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/167/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:07:17) > > > Review request for Default. > > > Summary > ------- > > ARM: Change how the AMBA device ID checking is done to make it more generic > > > Diffs > ----- > > src/dev/arm/RealView.py PRE-CREATION > src/dev/arm/amba_device.hh PRE-CREATION > src/dev/arm/amba_device.cc PRE-CREATION > src/dev/arm/amba_fake.cc PRE-CREATION > src/dev/arm/pl011.hh PRE-CREATION > src/dev/arm/pl011.cc PRE-CREATION > src/dev/arm/timer_sp804.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/167/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
