> On 2010-08-19 09:55:36, Nathan Binkert wrote: > > src/arch/arm/isa/insts/misc.isa, line 711 > > <http://reviews.m5sim.org/r/184/diff/1/?file=1892#file1892line711> > > > > What's this? Seems like random whitespace that should be deleted.
gone. > On 2010-08-19 09:55:36, Nathan Binkert wrote: > > src/arch/arm/tlb.cc, line 358 > > <http://reviews.m5sim.org/r/184/diff/1/?file=1894#file1894line358> > > > > Single space after // please. I know it's not in the style guide, but > > almost all other comments do this. fixed. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/184/#review244 ----------------------------------------------------------- On 2010-08-13 10:14:04, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/184/ > ----------------------------------------------------------- > > (Updated 2010-08-13 10:14:04) > > > Review request for Default. > > > Summary > ------- > > ARM: Implement CLREX > > > Diffs > ----- > > src/arch/arm/isa/formats/branch.isa 3c48b2b3cb83 > src/arch/arm/isa/formats/uncond.isa 3c48b2b3cb83 > src/arch/arm/isa/insts/misc.isa 3c48b2b3cb83 > src/arch/arm/tlb.hh 3c48b2b3cb83 > src/arch/arm/tlb.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/184/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
