> On 2010-08-17 15:11:44, Ali Saidi wrote: > > src/arch/arm/linux/atag.hh, line 92 > > <http://reviews.m5sim.org/r/165/diff/1/?file=1840#file1840line92> > > > > The style guide is silent on the matter
It is true that the style guide is silent, but I'd have to agree with Gabe. Either all on one line or on three lines. I won't fight though. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/165/#review212 ----------------------------------------------------------- On 2010-08-13 09:44:46, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/165/ > ----------------------------------------------------------- > > (Updated 2010-08-13 09:44:46) > > > Review request for Default. > > > Summary > ------- > > ARM: Add system for ARM/Linux and bootstrapping > > > Diffs > ----- > > src/arch/arm/ArmSystem.py 3c48b2b3cb83 > src/arch/arm/SConscript 3c48b2b3cb83 > src/arch/arm/faults.cc 3c48b2b3cb83 > src/arch/arm/linux/atag.hh PRE-CREATION > src/arch/arm/linux/system.hh PRE-CREATION > src/arch/arm/linux/system.cc PRE-CREATION > src/arch/arm/system.cc 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/165/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
