----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/203/#review275 -----------------------------------------------------------
Ship it! please change STATS: to stats: in the commit message. src/base/statistics.hh <http://reviews.m5sim.org/r/203/#comment410> Can you remove the space before the final ). I know you didn't add it. - Nathan On 2010-08-18 11:50:40, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/203/ > ----------------------------------------------------------- > > (Updated 2010-08-18 11:50:40) > > > Review request for Default. > > > Summary > ------- > > STATS: Fix off-by-one error in distributions. > > bkt size isn't evenly divisible by max-min and it would round down, > it's possible to sample a distribution and have no place to put the sample. > When this case occured the simulator would assert. > > > Diffs > ----- > > src/base/statistics.hh 3c48b2b3cb83 > > Diff: http://reviews.m5sim.org/r/203/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
