> On 2010-08-19 09:49:51, Nathan Binkert wrote:
> > Shouldn't this be folded into some other diff?
> 
> Ali Saidi wrote:
>     I'll fold it in to another change that needs it.

I don't know that that's the right thing to do. This doesn't fit backward in 
time because we can't go that far back, and it's used equally by a number of 
future changes. Folding it into a future change would just be tacking it on 
arbitrarily. While I don't think it's the right thing to do, I don't think it's 
serious enough to violently appose it either.


- Gabe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/172/#review238
-----------------------------------------------------------


On 2010-08-13 10:08:34, Ali Saidi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/172/
> -----------------------------------------------------------
> 
> (Updated 2010-08-13 10:08:34)
> 
> 
> Review request for Default.
> 
> 
> Summary
> -------
> 
> ARM: Add some registers for big loads/stores to support neon.
> 
> 
> Diffs
> -----
> 
>   src/arch/arm/registers.hh 3c48b2b3cb83 
> 
> Diff: http://reviews.m5sim.org/r/172/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ali
> 
>

_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to