----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/209/#review287 -----------------------------------------------------------
src/arch/x86/types.hh <http://reviews.m5sim.org/r/209/#comment416> Do you really need to include this here, or can you just include it in the .cc file? Perhaps because of the template <>, you do need to include it here. In general, I'd like to support overloading paramIn and paramOut better and have this be the general mechanism for serializing sub-objects. - Nathan On 2010-08-22 18:53:37, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/209/ > ----------------------------------------------------------- > > (Updated 2010-08-22 18:53:37) > > > Review request for Default. > > > Summary > ------- > > X86: Make the x86 ExtMachInst serializable with (UN)SERIALIZE_SCALAR. > > > Diffs > ----- > > src/arch/x86/SConscript 405f840c4ae1 > src/arch/x86/types.hh 405f840c4ae1 > src/arch/x86/types.cc PRE-CREATION > > Diff: http://reviews.m5sim.org/r/209/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
