----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/210/#review289 -----------------------------------------------------------
Ship it! Makes sense to me. (Though I don't know the code well) - Nathan On 2010-08-22 18:53:45, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/210/ > ----------------------------------------------------------- > > (Updated 2010-08-22 18:53:45) > > > Review request for Default. > > > Summary > ------- > > X86: Make the TLB fault instead of panic when something is unmapped in SE > mode. > > The fault object, if invoked, would then panic. This is a bit less direct, but > it means speculative execution won't panic the simulator. > > > Diffs > ----- > > src/arch/x86/faults.hh 405f840c4ae1 > src/arch/x86/faults.cc 405f840c4ae1 > src/arch/x86/tlb.cc 405f840c4ae1 > > Diff: http://reviews.m5sim.org/r/210/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
