----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/216/#review294 -----------------------------------------------------------
memset and bzero are the same thing. I'd personally rather even see some thing like 0xAA in the memset so that we can see what happened. - Nathan On 2010-08-23 02:32:09, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/216/ > ----------------------------------------------------------- > > (Updated 2010-08-23 02:32:09) > > > Review request for Default. > > > Summary > ------- > > CPU: Set a default value when readBytes faults. > > This was being done in read(), but if readBytes was called directly it > wouldn't happen. Also, instead of setting the memory blob being read to -1 > which would (I believe) require using memset with -1 as a parameter, this now > uses bzero. It's hoped that it's more specialized behavior will make it > slightly faster. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh ef798deb9a02 > > Diff: http://reviews.m5sim.org/r/216/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
