> On 2010-08-23 07:12:58, Nathan Binkert wrote: > > In reviewboard, it just looks like you deleted a bunch of stuff, though I > > guess you actually did an "hg mv"?
Yeah. In the patch itself those files all say something like this. diff --git a/src/arch/x86/apicregs.hh b/src/arch/x86/regs/apic.hh rename from src/arch/x86/apicregs.hh rename to src/arch/x86/regs/apic.hh Apparently either reviewboard or the reviewboard extension didn't understand that, or I didn't pass in the right magic option. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/215/#review293 ----------------------------------------------------------- On 2010-08-22 19:01:30, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/215/ > ----------------------------------------------------------- > > (Updated 2010-08-22 19:01:30) > > > Review request for Default. > > > Summary > ------- > > X86: Create a directory for files that define register indexes. > > This is to help tidy up arch/x86. These files should not be used external to > the ISA. > > > Diffs > ----- > > src/arch/x86/apicregs.hh ef798deb9a02 > src/arch/x86/emulenv.hh ef798deb9a02 > src/arch/x86/floatregs.hh ef798deb9a02 > src/arch/x86/insts/microfpop.cc ef798deb9a02 > src/arch/x86/insts/micromediaop.cc ef798deb9a02 > src/arch/x86/insts/microop.cc ef798deb9a02 > src/arch/x86/insts/microregop.cc ef798deb9a02 > src/arch/x86/insts/static_inst.cc ef798deb9a02 > src/arch/x86/interrupts.hh ef798deb9a02 > src/arch/x86/interrupts.cc ef798deb9a02 > src/arch/x86/intregs.hh ef798deb9a02 > src/arch/x86/isa.hh ef798deb9a02 > src/arch/x86/isa/includes.isa ef798deb9a02 > src/arch/x86/linux/syscalls.cc ef798deb9a02 > src/arch/x86/linux/system.cc ef798deb9a02 > src/arch/x86/miscregs.hh ef798deb9a02 > src/arch/x86/mmaped_ipr.hh ef798deb9a02 > src/arch/x86/nativetrace.cc ef798deb9a02 > src/arch/x86/predecoder.hh ef798deb9a02 > src/arch/x86/predecoder.cc ef798deb9a02 > src/arch/x86/process.cc ef798deb9a02 > src/arch/x86/registers.hh ef798deb9a02 > src/arch/x86/regs/apic.hh PRE-CREATION > src/arch/x86/regs/float.hh PRE-CREATION > src/arch/x86/regs/int.hh PRE-CREATION > src/arch/x86/regs/misc.hh PRE-CREATION > src/arch/x86/regs/segment.hh PRE-CREATION > src/arch/x86/segmentregs.hh ef798deb9a02 > src/arch/x86/system.cc ef798deb9a02 > src/arch/x86/tlb.hh ef798deb9a02 > src/arch/x86/tlb.cc ef798deb9a02 > src/arch/x86/utility.hh ef798deb9a02 > src/arch/x86/utility.cc ef798deb9a02 > > Diff: http://reviews.m5sim.org/r/215/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
