> On 2010-08-23 07:11:09, Nathan Binkert wrote: > > src/arch/alpha/ev5.cc, line 74 > > <http://reviews.m5sim.org/r/213/diff/1/?file=1998#file1998line74> > > > > Is this all duplicate code? > > Gabe Black wrote: > I'm not sure why it was there. If I had to guess, I'd say it was moved > there to factor out its Alpha-ness, replaced with the Interrupts object > mechanism at some point, and never deleted. There are several instances of > other functions called processInterrupts defined in the CPUs.
Yes, but is it somewhere else? I have a hard time believing that ALPHA_FS really works without this code. Ali, can you comment, did our switch to Tsunami make this irrelevant? - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/213/#review291 ----------------------------------------------------------- On 2010-08-22 19:01:17, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/213/ > ----------------------------------------------------------- > > (Updated 2010-08-22 19:01:17) > > > Review request for Default. > > > Summary > ------- > > ISA: Get rid of old, unused utility functions cluttering up the ISAs. > > > Diffs > ----- > > src/arch/alpha/ev5.cc 3d72ff41f9d2 > src/arch/alpha/utility.hh 3d72ff41f9d2 > src/arch/arm/utility.hh 3d72ff41f9d2 > src/arch/mips/mips_core_specific.hh 3d72ff41f9d2 > src/arch/mips/mips_core_specific.cc 3d72ff41f9d2 > src/arch/mips/utility.hh 3d72ff41f9d2 > src/arch/power/utility.hh 3d72ff41f9d2 > src/arch/sparc/utility.hh 3d72ff41f9d2 > src/arch/x86/utility.hh 3d72ff41f9d2 > src/cpu/o3/fetch.hh 3d72ff41f9d2 > src/cpu/ozone/front_end.hh 3d72ff41f9d2 > > Diff: http://reviews.m5sim.org/r/213/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
