----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/233/#review305 -----------------------------------------------------------
src/cpu/simple/atomic.cc <http://reviews.m5sim.org/r/233/#comment424> How about moving this check up to the surrounding if? else if (traceData && !DTRACE(ExecFaulting)) { That would fit into the flow of the code better, I think. - Gabe On 2010-08-23 09:34:20, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/233/ > ----------------------------------------------------------- > > (Updated 2010-08-23 09:34:20) > > > Review request for Default. > > > Summary > ------- > > CPU: Print out traces for faluting instructions when the flag for it > (ExecFaulting) is set > > > Diffs > ----- > > src/cpu/simple/atomic.cc 47d9409b2b7f > src/cpu/simple/timing.cc 47d9409b2b7f > > Diff: http://reviews.m5sim.org/r/233/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
