> On 2010-08-23 12:06:58, Nathan Binkert wrote: > > I asume that you have a meaningful commit message and that reviewboard > > screwed up. I don't want to be too anal here so feel free to overrule me, > > but is ltz a standard name in ARM? If not, perhaps we should try to > > standardize these names somehow. In Python, comparisons are named lt, gt, > > geq, leq, eq, and neq. It's not a big deal, but I didn't immediately know > > what ltz meant without looking at the code. Anyway I leave it up to you.
ltz -- less that zero. I think that is pretty standard and since it's used a fair amount short is nice. I'll add a comment to neon.isa. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/220/#review319 ----------------------------------------------------------- On 2010-08-23 09:38:55, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/220/ > ----------------------------------------------------------- > > (Updated 2010-08-23 09:38:55) > > > Review request for Default. > > > Summary > ------- > > ARM: Fix type comparison warnings in Neon. > > > Diffs > ----- > > src/arch/arm/isa/insts/neon.isa PRE-CREATION > src/arch/arm/isa/templates/neon.isa PRE-CREATION > > Diff: http://reviews.m5sim.org/r/220/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
