----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/219/#review328 -----------------------------------------------------------
Again, I can't review this very well. I say ship it unless someone points out something. src/arch/arm/faults.hh <http://reviews.m5sim.org/r/219/#comment438> Just so you guys all know, the colon should be on the next line and you should pack the arguments on as few lines as possible (assuming the 80 column rule) - Nathan On 2010-08-23 09:39:01, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/219/ > ----------------------------------------------------------- > > (Updated 2010-08-23 09:39:01) > > > Review request for Default. > > > Summary > ------- > > ARM: Implement CPACR register and return Undefined Instruction when FP access > is disabled. > > > Diffs > ----- > > src/arch/arm/faults.hh 47d9409b2b7f > src/arch/arm/faults.cc 47d9409b2b7f > src/arch/arm/insts/static_inst.hh 47d9409b2b7f > src/arch/arm/isa.cc 47d9409b2b7f > src/arch/arm/isa/insts/fp.isa 47d9409b2b7f > src/arch/arm/isa/insts/neon.isa PRE-CREATION > src/arch/arm/isa/operands.isa 47d9409b2b7f > src/arch/arm/isa/templates/vfp.isa 47d9409b2b7f > src/arch/arm/miscregs.hh 47d9409b2b7f > src/arch/arm/process.cc 47d9409b2b7f > src/arch/arm/utility.hh 47d9409b2b7f > > Diff: http://reviews.m5sim.org/r/219/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
