> On 2010-10-10 20:03:00, Ali Saidi wrote: > > src/arch/sparc/isa.cc, line 140 > > <http://reviews.m5sim.org/r/268/diff/1/?file=4075#file4075line140> > > > > This isn't performance critical, so panic() would probably be better.
Ok. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/268/#review369 ----------------------------------------------------------- On 2010-10-09 15:33:40, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/268/ > ----------------------------------------------------------- > > (Updated 2010-10-09 15:33:40) > > > Review request for Default. > > > Summary > ------- > > SPARC: Make SPARC's ISA's clear function initialize everything it should. > > Also make it not set some pointers to NULL potentially introducing a memory > leak. That should be done in the constructor. > > > Diffs > ----- > > src/arch/alpha/isa.hh fde051006c8c > src/arch/sparc/isa.hh fde051006c8c > src/arch/sparc/isa.cc fde051006c8c > > Diff: http://reviews.m5sim.org/r/268/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
